Skip to content

Set numpy docs link for sphinx gallery back to stable #14162

New issue
New issue
Closed
Closed
Set numpy docs link for sphinx gallery back to stable#14162
Labels
DocsUpstream Action RequiredWas: Upstream Fix Required

Description

@mhvk
mhvk
opened on Dec 9, 2022

In #14140, where we unpinned sphinx, the numpy link in the gallery was set to devdocs, since stable gave errors. It should be set back. Perhaps with the release of numpy 1.24, the docs will be OK again. See

astropy/docs/conf.py

Lines 340 to 342 in d31499b

# The stable numpy search js isn't loadable at the moment (2022-12-07)
# It seems to be valid js but it's not valid json so sphinx wont load it.
"numpy": "https://numpy.org/devdocs/",

Activity

  1. mhvk
    added
    Docs
    on Dec 9, 2022
  2. mhvk
    added this to the v5.3 milestone on Dec 9, 2022
  3. pllim
    added
    Downstream Fix Required
    Upstream Action RequiredWas: Upstream Fix Required
    and removed
    Downstream Fix Required
    on Dec 15, 2022
  4. pllim
    removed this from the v5.3 milestone on Dec 19, 2022

  5. pllim commented on Dec 19, 2022

    @pllim
    pllim
    on Dec 19, 2022
    Member

    We have to backport this, so I removed the milestone. I don't think it is release critical.

  6. pllim commented on Jan 25, 2023

    @pllim
    pllim
    on Jan 25, 2023
    Member

    Done in #14288

  7. pllim
    closed this as completedon Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    DocsUpstream Action RequiredWas: Upstream Fix Required

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions