Skip to content

Move hour_angle() and lst() methods from RA to coordinates #1385

Closed

Description

@taldcroft

In the discussion related to #1310 it was agreed to move the RA.hour_angle() and RA.lst() methods into the coordinates class.

See here and commentary above for justification.

Moving these two methods into coordinates is not a completely trivial migration, since as mentioned there can be subtleties. It also seems reasonable to expect that these two methods should be available for non-Equatorial coordinate systems (e.g. Galactic) and that the appropriate transformations would be done.

For #1310, the methods and associated tests will just be dropped, with this issue providing the placeholder to reinstate them with Coordinates, probably as SphericalCoordinatesBase methods. The links into the 0.2.4 branch above provide the reference implementation. The 0.2.4 tests are here.

Activity

  1. eteq commented on Oct 25, 2013

    @eteq
    Member

    Given the discussion in #1418, I'm pushing this to the next version. We'll need to integrate it with the way of calculating LST, anyway.

  2. eteq commented on May 14, 2014

    @eteq
    Member

    Time has passed this one by, as it's all no longer relevant to the current master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions