Skip to content

TST: Unpin numpy in pyinstaller job #12688

@pllim

Description

@pllim

Follow-up of:

Remove this pin and make sure CI does not fail for that test no more:

astropy/tox.ini

Line 150 in 3d522eb

numpy==1.21.*

Currently, with numpy 1.22.0, it complains about numpy.distutils but when you add back --collect-submodules numpy.distutils removed in #12655 , it complains about _private:

  File "astropy/units/quantity_helper/function_helpers.py", line 42, in <module>
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "PyInstaller/loader/pyimod03_importers.py", line 476, in exec_module
  File "numpy/lib/recfunctions.py", line 16, in <module>
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "PyInstaller/loader/pyimod03_importers.py", line 476, in exec_module
  File "numpy/testing/__init__.py", line 17, in <module>
NameError: name '_private' is not defined

Need someone familiar with pyinstaller to investigate and fix.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions