Skip to content

Deprecate treat_deprecations_as_exceptions #12404

Closed

Description

@mhvk

Follow-up in #12389, where we had to fix our machinery, and where @astrofrog noted it should be possible to do this just with pytest now.

Activity

  1. pllim commented on Nov 11, 2021

    @pllim
    Member

    Have to make sure downstream packages are okay with this first?

  2. pllim commented on Dec 9, 2021

    @pllim
    Member

    2021-12-09 -- I asked astropy-dev for opinions on this. We'll see!

  3. astrofrog commented on Dec 10, 2021

    @astrofrog
    Member

    If we do this we should include a section in our docs explaining how to migrate to the pytest way of doing things.

  4. pllim commented on Dec 16, 2021

    @pllim
    Member

    2021-12-16 -- No objection to proceed from infrastructure tag up. We should do this early in 5.1 release cycle.

  5. pllim commented on Dec 22, 2021

    @pllim
    Member

    Wow, I totally forgot about #6761. I don't think we can deprecate just this. It makes more sense to deprecate all these together:

    • astropy.io.ascii.tests.common.raises
    • astropy.tests.helper.catch_warnings
    • astropy.tests.helper.enable_deprecations_as_exceptions
    • astropy.tests.helper.raises
    • astropy.tests.helper.treat_deprecations_as_exceptions

    🔥

  6. pllim commented on Dec 22, 2021

    @pllim
    Member

    Looks like @taldcroft added astropy.io.ascii.tests.common.raises 10 years ago in #154. 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions