Repository navigation
TST: test_write_extra_SkyCoord_cols fails on Azure Pipelines #12299
Description
Originally discussed in #12170 and then ignored in #12292. This test is from #11897.
Specifically see #12170 (comment) and related discussions.
Desired outcome: We figure out why it is failing, address it accordingly, and have it run again in Azure Pipelines.
cc @Suyog7130 @hamogu @aaryapatil @taldcroft @Cadair @dhomeier
Activity
aaryapatil commentedon Oct 26, 2021
I will have time in the evening today to look at this in detail. Hopefully we resolve it soon 🙏
dhomeier commentedon Oct 26, 2021
@aaryapatil I have pushed an attempt to fix this and some other formatting bugs in #12302 if you want to have a look.
hamogu commentedon Oct 26, 2021
Now we have two PRs: #12301 and #12302. Need to make sure they don't overlap, but I imagine there will be conflicts. Both by io.ascii maintainers, so I feel I need to open one, too, to be part of the team!
dhomeier commentedon Oct 26, 2021
They are quite orthogonal in scope, but conflicts there will be for sure.
Seem to both resolve the test failure anyway, although I am a bit puzzled you could even call
pytest.raises(UserWarning)...🤔pllim commentedon Oct 27, 2021
That is because of this:
astropy/setup.cfg
Lines 121 to 122 in 3353a7d
It turns warning into exception. I think it should also work if you use
pytest.warns(UserWarning)even with that setting? Then it would work whether the test suite is grabbing settings fromsetup.cfgor not.aaryapatil commentedon Oct 27, 2021
Looks like the issue already has a fix (?) 🥳
dhomeier commentedon Oct 27, 2021
Yes, that's what I have been doing for #12302, and also running the
assertions outside the context. Thanks, that might explain some of the mystery!pllim commentedon Oct 27, 2021
Wow, looks like people have been busy while I was sleeping. 😅