Skip to content

Version limitations for optional dependencies are ignored #12121

Closed

Description

@bsipocz

This may be just the expected side effect of how packaging/pip works. Nevertheless, it may be something worth at least documenting as users may run into surprises, too.

PR #11934 dropped the support for mpl 3.0.x, yet the tests for using version 3.0.3 happily run rather than raising an error or try to update.

https://app.circleci.com/pipelines/github/astropy/astropy/6851/workflows/22d51a94-314f-43f9-8f66-1732154800d2/jobs/92719

Activity

  1. saimn commented on Sep 3, 2021

    @saimn
    Contributor

    I tried locally on another repo and it works. So probably another cache issue with CircleCI. Actually it shouldn't have run image-tests-mpl303 since you deleted this job in the PR ?

  2. bsipocz commented on Sep 3, 2021

    @bsipocz
    MemberAuthor

    I've deleted that job in a later commit.

  3. neutrinoceros commented on Jan 21, 2026

    @neutrinoceros
    Contributor

    oldestdeps jobs recently received consolidations that I think make this issue moot (at least for the CI part). I suggest closing this.

  4. bsipocz commented on Jan 21, 2026

    @bsipocz
    MemberAuthor

    FWIW, this was never a CI issue.

  5. pllim commented on Jan 21, 2026

    @pllim
    Member

    Even so, if users now install oldest deps as we do in CI, they shouldn't accidentally be using too old a version. If people do pip install a la cart, then pip now complains if it finds conflict in resolving the pins, and it is also not our problem. So, what remains to be addressed here?

  6. bsipocz commented on Jan 21, 2026

    @bsipocz
    MemberAuthor

    yeap, it's upstream. I believe pip still won't complain for optional dependency version limits, those are just ignored -- and that was the original problem. No need to reopen, but it needed to be clarified this wasn't a CI issue and is very likely is still an issue.

  7. pllim commented on Jan 21, 2026

    @pllim
    Member

    but it needed to be clarified this wasn't a CI issue and is very likely is still an issue

    Do you have a suggestion where to add this to doc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions