You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix or remove io.ascii C reader parallel code #10882
As discussed in #8858, parallel reading with the io.ascii fast C reader is currently broken.
In #10880 I made the parallel reading option fall back to serial reading for now. I think that we should either fix this in a timely way or remove the parallel code to avoid code rot. I'm milestoning this as v4.2 but we could change to v4.3 if this is too aggressive.
Should there be a deprecation cycle for the parallel keyword or it's safe to just remove it? The users were being warned with a warning if they used parallel=True in their code.
Activity
pllim commentedon Oct 16, 2020
@taldcroft did mention that 4.2 is too aggressive over at #10880 (comment) , so I took the liberty to move the milestone. FYI
pllim commentedon Apr 28, 2021
I don't see any PR associated with this issue. I am removing the milestone.
MridulS commentedon Dec 17, 2023
Looks like this hasn't been touched in a while, does it make sense to remove the parallel code path to remove dead code?
taldcroft commentedon Dec 18, 2023
I'm not sure of the status in general right now, but if is broken we should take it out rather than try to fix it.
MridulS commentedon Feb 23, 2024
Should there be a deprecation cycle for the
parallelkeyword or it's safe to just remove it? The users were being warned with a warning if they usedparallel=Truein their code.taldcroft commentedon Feb 23, 2024
Yeah, that warning has been there for 3+ years, so let's jut remove the keyword and get it done.