Skip to content

Fix or remove io.ascii C reader parallel code #10882

Closed

Description

@astrofrog

As discussed in #8858, parallel reading with the io.ascii fast C reader is currently broken.

In #10880 I made the parallel reading option fall back to serial reading for now. I think that we should either fix this in a timely way or remove the parallel code to avoid code rot. I'm milestoning this as v4.2 but we could change to v4.3 if this is too aggressive.

cc @taldcroft @dhomeier @saimn

Activity

  1. added this to the v4.2 milestone on Oct 16, 2020
  2. modified the milestones: v4.2, v4.3 on Oct 16, 2020
  3. pllim commented on Oct 16, 2020

    @pllim
    Member

    @taldcroft did mention that 4.2 is too aggressive over at #10880 (comment) , so I took the liberty to move the milestone. FYI

  4. pllim commented on Apr 28, 2021

    @pllim
    Member

    I don't see any PR associated with this issue. I am removing the milestone.

  5. removed this from the v4.3 milestone on Apr 28, 2021
  6. MridulS commented on Dec 17, 2023

    @MridulS
    Contributor

    Looks like this hasn't been touched in a while, does it make sense to remove the parallel code path to remove dead code?

  7. taldcroft commented on Dec 18, 2023

    @taldcroft
    Member

    I'm not sure of the status in general right now, but if is broken we should take it out rather than try to fix it.

  8. MridulS commented on Feb 23, 2024

    @MridulS
    Contributor

    Should there be a deprecation cycle for the parallel keyword or it's safe to just remove it? The users were being warned with a warning if they used parallel=True in their code.

  9. taldcroft commented on Feb 23, 2024

    @taldcroft
    Member

    Yeah, that warning has been there for 3+ years, so let's jut remove the keyword and get it done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions