Skip to content

TST: TestManipulation::test_broadcast_to fails with older dependencies #10471

Closed

Description

@pllim

Description

TestManipulation::test_broadcast_to fails on Windows locally when I run pytest astropy/coordinates/tests/test_shape_manipulation.py.

Expected behavior

Test to pass.

Actual behavior

============================= test session starts =============================
platform win32 -- Python 3.7.1, pytest-5.4.1, py-1.7.0, pluggy-0.13.1

Running tests with Astropy version 4.2.dev240+gc3c09942c.
Running tests in astropy/coordinates/tests/test_shape_manipulation.py.

Date: 2020-06-08T17:03:35

Platform: Windows-10-10.0.18362-SP0

Executable: c:\...\miniconda3\envs\py37\python.exe

Full Python Version:
3.7.1 | packaged by conda-forge | (default, Nov 13 2018, 19:01:41) [MSC v.1900 64 bit (AMD64)]

encodings: sys: utf-8, locale: cp1252, filesystem: utf-8
byteorder: little
float info: dig: 15, mant_dig: 15

Package versions:
Numpy: 1.16.3
Scipy: 1.3.1
Matplotlib: not available
h5py: 2.10.0
Pandas: 0.24.2
Cython: 0.29.10
Scikit-image: 0.14.2
asdf: 2.6.0

Using Astropy options: remote_data: none.

rootdir: ..., inifile: setup.cfg
plugins: asdf-2.6.0, hypothesis-5.1.5, arraydiff-0.2, astropy-header-0.1.2, cov-2.8.1, doctestplus-0.6.1, filter-subpackage-0.1.1, forked-0.2, openfiles-0.4.0, remotedata-0.3.1, xdist-1.24.1
collected 11 items

astropy\coordinates\tests\test_shape_manipulation.py ..........F         [100%]

================================== FAILURES ===================================
_____________________ TestManipulation.test_broadcast_to ______________________

self = <astropy.coordinates.tests.test_shape_manipulation.TestManipulation object at 0x0000025B0A1C5668>

    def test_broadcast_to(self):
        s1_broadcast = np.broadcast_to(self.s1, (20, 6, 7))
        assert s1_broadcast.shape == (20, 6, 7)
>       assert np.all(s1_broadcast.data.lon == self.s1.data.lon[np.newaxis])
E       AttributeError: 'memoryview' object has no attribute 'lon'

astropy\coordinates\tests\test_shape_manipulation.py:346: AttributeError

UPDATE: Looks like TestManipulation is completely skipped in the Windows job in CI because they are marked as remote data.

UPDATE: Looks like this is not Windows-specific, as the CI also sees it with Linux job with older dependencies.

Activity

  1. changed the title [-]TST: TestManipulation::test_broadcast_to fails on Windows locally[/-] [+]TST: TestManipulation::test_broadcast_to fails with older dependencies[/+] on Jun 8, 2020
  2. mhvk commented on Jun 9, 2020

    @mhvk
    Contributor

    Ah, well, at least this one is simple: I forgot to add needs_array_function and because of remote_data, that was not seen. I'll push up a fix!

  3. mhvk commented on Jun 9, 2020

    @mhvk
    Contributor

    See #10474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions