Repository navigation
TST: Why so many conftest.py files? #10310
Description
Description
I see many copies of conftest.py files buried in the package. The most troubling are astropy/conftest.py and conftest.py that contain duplicated code.
astropy/coordinates/tests/conftest.pyastropy/table/tests/conftest.pyastropy/wcs/tests/conftest.pyastropy/wcs/wcsapi/conftest.pyastropy/conftest.pydocs/conftest.pyconftest.py
Expected behavior
One and only one conftest.py at root directory.
Proposed solution
- Move stuff from lower level
conftest.pyfiles to the root level one. Eliminated duplicate code. - Move subpackage specfici test helper functions into
subpackage/tests/utils.pyif they are not needed at the rootconftest.pylevel.
Need to know
- Is there a reason why proposed solution above wouldn't work?
Activity
Cadair commentedon May 5, 2020
Having lower level conftest files which provide subpackage specific pytest fixtures is the recommended way of doing it. ref
I agree it can be a little magic as you have to look for conftest files to see where your fixtures are coming from, but I think it would cause more issues to try and work around pytest (pytest is sufficiently magic you are better off accepting the magic and becoming one with it than fighting against it imo).
I do wonder if the very top most level
conftest.pyfile should be removed, I know pytest has been deprecating stuff in there because the behaviour is ill defined.pllim commentedon May 5, 2020
Really? I thought it is the other way around? I remember
pytestchastising me in another package for having lower levelconftest.pyand implored me to use root-level one.Besides, we need the root-level one to run
pytest ...from root level during dev testing locally.Cadair commentedon May 6, 2020
🤷
pllim commentedon Jun 17, 2020
I think @astrofrog said something about the test runner. Ah well.