Skip to content

Commit 96774df

Browse files
RFC: avoid PDEP-8 deprecation warnings from pandas.DataFrame (#20332)
1 parent ad9d20f commit 96774df

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎astropy/table/_dataframes.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ def to_df(
281281

282282
# Pandas-like index
283283
if index:
284-
df_native.set_index(index, inplace=True, drop=True)
284+
df_native = df_native.set_index(index, drop=True)
285285

286286
return df_native
287287

@@ -315,7 +315,7 @@ def from_df(
315315
index_name = str(df.index.name or "index")
316316
while index_name in df.columns:
317317
index_name = "_" + index_name + "_"
318-
df.reset_index(index_name, inplace=True, drop=False)
318+
df = df.reset_index(index_name, drop=False)
319319

320320
# Narwhals layer, must convert to eager
321321
df_nw = nw.from_native(df)

‎astropy/timeseries/tests/test_sampled.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ def test_pandas():
323323

324324
df1 = pandas.DataFrame()
325325
df1["a"] = [1, 2, 3]
326-
df1.set_index(pandas.DatetimeIndex(INPUT_TIME.datetime64), inplace=True)
326+
df1 = df1.set_index(pandas.DatetimeIndex(INPUT_TIME.datetime64))
327327

328328
ts = TimeSeries.from_pandas(df1)
329329
assert_equal(ts.time.isot, INPUT_TIME.isot)

‎docs/timeseries/pandas.rst‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Consider a concise example starting from a :class:`~pandas.DataFrame`:
3636
>>> df = pandas.DataFrame()
3737
>>> df['a'] = [1, 2, 3]
3838
>>> times = np.array(['2015-07-04', '2015-07-05', '2015-07-06'], dtype=np.datetime64)
39-
>>> df.set_index(pandas.DatetimeIndex(times), inplace=True)
39+
>>> df = df.set_index(pandas.DatetimeIndex(times))
4040
>>> df
4141
a
4242
2015-07-04 1

0 commit comments

Comments
 (0)