Skip to content

Respect Astropy IERS URL configuration - #418

Merged
bmorris3 merged 1 commit into
astropy:masterfrom
lpsinger:respect-astropy-utils-iers-conf
Oct 29, 2019
Merged

Respect Astropy IERS URL configuration#418
bmorris3 merged 1 commit into
astropy:masterfrom
lpsinger:respect-astropy-utils-iers-conf

Conversation

@lpsinger

@lpsinger lpsinger commented Aug 8, 2019

Copy link
Copy Markdown
Contributor

No description provided.

wtgee
wtgee reviewed Aug 20, 2019
View reviewed changes

@wtgee wtgee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be solved in astropy itself as per https://github.com/astropy/astropy/issues/8981, but giving feedback here anyway. Thanks @lpsinger!

Comment thread astroplan/utils.py Resolved
Comment thread astroplan/utils.py Resolved
Comment thread astroplan/utils.py Resolved
@lpsinger
lpsinger force-pushed the respect-astropy-utils-iers-conf branch from 57471a6 to 8ef69aa Compare August 20, 2019 23:12
@lpsinger
lpsinger force-pushed the respect-astropy-utils-iers-conf branch from 8ef69aa to 8c00228 Compare August 21, 2019 00:02
@wtgee wtgee mentioned this pull request Aug 22, 2019
Open
@wtgee

wtgee commented Sep 8, 2019

Copy link
Copy Markdown
Contributor

FWIW, I'm using this patch in my fork because I don't have any other work around for our live telescopes. It's working great. Would be nice to get it merged. @bmorris3 maybe you can kick off the tests again?

@wtgee

wtgee commented Oct 20, 2019

Copy link
Copy Markdown
Contributor

@bmorris3 @lpsinger anything I can do to help get some movement on this? I have to do a lot of manual restarting of our CI tests just because the IERS download has failed and this will help fix that. Thanks!

@wtgee

wtgee commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

@bmorris3 also, see comment in astropy/astropy-iers-data#20.

The default IERS servers are going down in two days and will be down for 6 months.

@bmorris3

bmorris3 commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

@wtgee Sorry for the delay. These are scary times indeed! Tests restarted, will merge pending tests pass.

@bmorris3

bmorris3 commented Oct 22, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

This build is failing with the following peculiar error:

sh: 0: Can't open /etc/init.d/xvfb

I'm going to see if I can find the source...

@wtgee

wtgee commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

This build is failing with the following peculiar error:

sh: 0: Can't open /etc/init.d/xvfb

I'm going to see if I can find the source...

Not sure why it's giving an error with these changes, but it's part of the matplotlib testing:

astroplan/.travis.yml

Lines 91 to 96 in 4693ed8

# This is needed to make matplotlib plot testing work
- if [[ $SETUP_CMD == test* && $TRAVIS_OS_NAME == 'linux' ]]; then
export DISPLAY=:99.0;
sh -e /etc/init.d/xvfb start;
export QT_API=pyqt;
fi

@bmorris3

bmorris3 commented Oct 24, 2019

Copy link
Copy Markdown
Contributor

@bsipocz Any chance you're familiar with the above line of code in the testing infrastructure? We're not doing any mpl tests, so it's possible we could just remove this line...?

@wtgee wtgee mentioned this pull request Oct 24, 2019
Closed
@bsipocz

bsipocz commented Oct 24, 2019

Copy link
Copy Markdown
Member

Yes, that whole section is very obsolete and can be removed.

However it doesn't seem to be true that you don't do mpl tests, there is at least one in test_sky.py, even though it may be a dummy one.

Anyway, the current way to set this up is to use set SETUP_XVFB=True in the global variable part of the travis config.

@gnthibault gnthibault mentioned this pull request Oct 24, 2019
Open
@bmorris3 bmorris3 mentioned this pull request Oct 25, 2019
Merged
@AnthonyHorton AnthonyHorton mentioned this pull request Oct 28, 2019
Closed
@bmorris3
bmorris3 merged commit 8c00228 into astropy:master Oct 29, 2019
@lpsinger
lpsinger deleted the respect-astropy-utils-iers-conf branch October 29, 2019 13:57
@wtgee wtgee mentioned this pull request Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@wtgee wtgee wtgee left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lpsinger @wtgee @bmorris3 @bsipocz