Skip to content

Change to use new SkyCoord prints - #273

Merged
eteq merged 2 commits into
astropy:masterfrom
bsipocz:docs_skycoord_print_style
Feb 17, 2017
Merged

eteq merged 2 commits into
astropy:masterfrom
bsipocz:docs_skycoord_print_style

Conversation

@bsipocz

@bsipocz bsipocz commented Dec 21, 2016 •

Copy link
Copy Markdown
Member

Numpy 1.12 will have a new array printing style, thus the SkyCoord changed its in astropy version 1.3 in astropy/astropy#5423. This PR fixes the docstring examples to use the new style, and skip running doctest with older astropy versions.

@eteq

eteq commented Feb 16, 2017

Copy link
Copy Markdown
Member

This effectively has the side-affect of requiring astropy 1.3 for these doctests to work... But I (and @bsipocz) aren't entirely sure if this way of requiring 1.3 will make the others skip if so, that's fine, but will need to merge the other PRs and re-run the tests here to confirm.

@bsipocz
bsipocz force-pushed the docs_skycoord_print_style branch from d325c4c to 632dfaa Compare February 16, 2017 22:40
@bsipocz

bsipocz commented Feb 16, 2017

Copy link
Copy Markdown
Member Author

tests with astropy 1.2 are running here: https://travis-ci.org/bsipocz/astroplan/builds/202430715
(there will be fails though as I haven't merged 285 in the test branch)

@eteq

eteq commented Feb 17, 2017 •

Copy link
Copy Markdown
Member

I just tried this locally, and it seems to be OK with 1.2 aside of course from the problems that #285 fixes... And it + #285 seems to get all the test passing on 1.3 . So I'll merge this and then it'll only be #285 left to discuss.

@eteq
eteq merged commit 5617724 into astropy:master Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants