This repository was archived by the owner on May 22, 2025. It is now read-only.
Add NATIVE_LOAD_EXCEPTIONS to BaseDatabase as it is being overloaded
#1324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunank200
requested review from
dimberman,
feluelle,
pankajastro,
pankajkoti,
tatiana and
utkarsharma2
as code owners
sunank200
changed the title
NATIVE_LOAD_EXCEPTIONSNATIVE_LOAD_EXCEPTIONS to BaseDatabase as it is being overloaded
kaxil
approved these changes
Nov 29, 2022
Codecov ReportBase: 95.71% // Head: 95.00% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1324 +/- ##
==========================================
- Coverage 95.71% 95.00% -0.72%
==========================================
Files 19 71 +52
Lines 677 3304 +2627
Branches 68 381 +313
==========================================
+ Hits 648 3139 +2491
- Misses 18 101 +83
- Partials 11 64 +53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
phanikumv
approved these changes
Nov 29, 2022
2 tasks
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 29, 2022
The change apache#27912 fixed and unified behaviour of DBApiHooks across the board, but it missed two places where sql was mis-used and overridden in exasol and snowflake hooks. The check for "sql" type did not use the original sql parameter value but the one that was overridden later in the run method implementation. The fix is the same as applied in Databricks Hook and DBAPI generic run methods - using consistent typing and separate variable to convert the sql string into sql list. Related: astronomer/astro-sdk#1324
potiuk
added a commit
to apache/airflow
that referenced
this pull request
Nov 30, 2022
…27997) The change #27912 fixed and unified behaviour of DBApiHooks across the board, but it missed two places where sql was mis-used and overridden in exasol and snowflake hooks. The check for "sql" type did not use the original sql parameter value but the one that was overridden later in the run method implementation. The fix is the same as applied in Databricks Hook and DBAPI generic run methods - using consistent typing and separate variable to convert the sql string into sql list. Related: astronomer/astro-sdk#1324
jrggggg
pushed a commit
to jrggggg/airflow
that referenced
this pull request
Dec 1, 2022
…pache#27997) The change apache#27912 fixed and unified behaviour of DBApiHooks across the board, but it missed two places where sql was mis-used and overridden in exasol and snowflake hooks. The check for "sql" type did not use the original sql parameter value but the one that was overridden later in the run method implementation. The fix is the same as applied in Databricks Hook and DBAPI generic run methods - using consistent typing and separate variable to convert the sql string into sql list. Related: astronomer/astro-sdk#1324
sunank200
added a commit
that referenced
this pull request
Dec 1, 2022
#1324) # Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> - Add the `NATIVE_LOAD_EXCEPTIONS` to BaseDatabase as it is being overloaded. <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> related to #1312 as change was not correct ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Add the `NATIVE_LOAD_EXCEPTIONS` to BaseDatabase as it is being overloaded. ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary (cherry picked from commit 0c64f48)
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Mar 30, 2023
…#27997) The change #27912 fixed and unified behaviour of DBApiHooks across the board, but it missed two places where sql was mis-used and overridden in exasol and snowflake hooks. The check for "sql" type did not use the original sql parameter value but the one that was overridden later in the run method implementation. The fix is the same as applied in Databricks Hook and DBAPI generic run methods - using consistent typing and separate variable to convert the sql string into sql list. Related: astronomer/astro-sdk#1324 GitOrigin-RevId: 2e7a4bcb550538283f28550208b01515d348fb51
ahidalgob
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2023
…#27997) The change #27912 fixed and unified behaviour of DBApiHooks across the board, but it missed two places where sql was mis-used and overridden in exasol and snowflake hooks. The check for "sql" type did not use the original sql parameter value but the one that was overridden later in the run method implementation. The fix is the same as applied in Databricks Hook and DBAPI generic run methods - using consistent typing and separate variable to convert the sql string into sql list. Related: astronomer/astro-sdk#1324 GitOrigin-RevId: 2e7a4bcb550538283f28550208b01515d348fb51
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 19, 2024
…#27997) The change #27912 fixed and unified behaviour of DBApiHooks across the board, but it missed two places where sql was mis-used and overridden in exasol and snowflake hooks. The check for "sql" type did not use the original sql parameter value but the one that was overridden later in the run method implementation. The fix is the same as applied in Databricks Hook and DBAPI generic run methods - using consistent typing and separate variable to convert the sql string into sql list. Related: astronomer/astro-sdk#1324 GitOrigin-RevId: 2e7a4bcb550538283f28550208b01515d348fb51
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 8, 2024
…#27997) The change #27912 fixed and unified behaviour of DBApiHooks across the board, but it missed two places where sql was mis-used and overridden in exasol and snowflake hooks. The check for "sql" type did not use the original sql parameter value but the one that was overridden later in the run method implementation. The fix is the same as applied in Databricks Hook and DBAPI generic run methods - using consistent typing and separate variable to convert the sql string into sql list. Related: astronomer/astro-sdk#1324 GitOrigin-RevId: 2e7a4bcb550538283f28550208b01515d348fb51
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 3, 2025
…#27997) The change #27912 fixed and unified behaviour of DBApiHooks across the board, but it missed two places where sql was mis-used and overridden in exasol and snowflake hooks. The check for "sql" type did not use the original sql parameter value but the one that was overridden later in the run method implementation. The fix is the same as applied in Databricks Hook and DBAPI generic run methods - using consistent typing and separate variable to convert the sql string into sql list. Related: astronomer/astro-sdk#1324 GitOrigin-RevId: 2e7a4bcb550538283f28550208b01515d348fb51
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
NATIVE_LOAD_EXCEPTIONSto BaseDatabase as it is being overloaded.related to #1312 as change was not correct
What is the new behavior?
NATIVE_LOAD_EXCEPTIONSto BaseDatabase as it is being overloaded.Does this introduce a breaking change?
No
Checklist