This repository was archived by the owner on May 22, 2025. It is now read-only.
Improve logging for load_file #1312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feluelle
requested review from
dimberman,
pankajastro,
pankajkoti,
sunank200,
tatiana and
utkarsharma2
as code owners
Codecov ReportBase: 94.91% // Head: 95.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1312 +/- ##
==========================================
+ Coverage 94.91% 95.71% +0.79%
==========================================
Files 52 19 -33
Lines 2617 677 -1940
Branches 311 68 -243
==========================================
- Hits 2484 648 -1836
+ Misses 82 18 -64
+ Partials 51 11 -40 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kaxil
approved these changes
Nov 28, 2022
kaxil
reviewed
Nov 28, 2022
Collaborator
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
One test failed for Airflow 2.4 and 2.2.5:
google.api_core.exceptions.BadRequest: 400 Provided Schema does not match Table astronomer-dag-authoring:first_table_schema._tmp_gcuqy9jbp3wxal8q0uqwb8jrk2a2zr6zage4t0g. Field id has changed mode from REQUIRED to NULLABLE
pankajkoti
approved these changes
Nov 29, 2022
Contributor
I checked this and seems that it is because we explicitly specify ID is primary key in the
As a result, the schema for the target tables have whereas, the So perhaps should we add the |
pankajkoti
force-pushed
the
feature/improve-logging-load-file
branch
from
da7b0d3 to
8574062
Compare
Contributor
|
I tried doing that(specifying columns), but got the following error, so reverting my commit.
|
10 tasks
2 tasks
kaxil
pushed a commit
that referenced
this pull request
Nov 29, 2022
#1324) # Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> - Add the `NATIVE_LOAD_EXCEPTIONS` to BaseDatabase as it is being overloaded. <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> related to #1312 as change was not correct ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Add the `NATIVE_LOAD_EXCEPTIONS` to BaseDatabase as it is being overloaded. ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary
sunank200
pushed a commit
that referenced
this pull request
Dec 1, 2022
# Description ## What is the current behavior? Currently, we don't have any logging for native nor pandas _load_file_. This makes it harder for users to follow the operations. related: #1263 ## What is the new behavior? We now have log statements for native, pandas as well as fallback indication. ## Does this introduce a breaking change? No. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary (cherry picked from commit 279c7d1)
sunank200
added a commit
that referenced
this pull request
Dec 1, 2022
#1324) # Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> - Add the `NATIVE_LOAD_EXCEPTIONS` to BaseDatabase as it is being overloaded. <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> related to #1312 as change was not correct ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Add the `NATIVE_LOAD_EXCEPTIONS` to BaseDatabase as it is being overloaded. ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary (cherry picked from commit 0c64f48)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
Currently, we don't have any logging for native nor pandas load_file. This makes it harder for users to follow the operations.
related: #1263
What is the new behavior?
We now have log statements for native, pandas as well as fallback indication.
Does this introduce a breaking change?
No.
Checklist