Skip to content

Comments

Add Houston API 1.0.1 support - remove desiredRuntimeVersion and AC fields#1988

Merged
neel-astro merged 5 commits intomainfrom
houston-api-1.1.0-support
Dec 15, 2025
Merged

Add Houston API 1.0.1 support - remove desiredRuntimeVersion and AC fields#1988
neel-astro merged 5 commits intomainfrom
houston-api-1.1.0-support

Conversation

@Simpcyclassy
Copy link
Member

@Simpcyclassy Simpcyclassy commented Nov 28, 2025 •
edited
Loading

Description

Note: This impacts APC 1.1.0 release but for local dev this is useful for post 1.0.1 which is still considered 1.0.1 in for the dev development phase

Adds version 1.0.1 GraphQL queries to support Houston API schema changes where desiredAirflowVersion and desiredRuntimeVersion fields have been removed from the Deployment type.

Changes:

  • Added 1.0.1 version queries for:
    • DeploymentCreateRequest - uses upsertDeployment mutation
    • DeploymentsGetRequest - removes deprecated airflow version fields
    • PaginatedDeploymentsGetRequest - removes deprecated airflow version fields
    • DeploymentUpdateRequest - uses upsertDeployment mutation
    • DeploymentGetRequest - removes desiredAirflowVersion and desiredRuntimeVersion

Problem:
When deploying with the CLI against Houston versions that have removed these fields, users encounter:

Error: failed to get deployment info: Some fields requested by the CLI are not available in the server schema.

The underlying GraphQL errors are:

  • Cannot query field "desiredAirflowVersion" on type "Deployment"
  • Cannot query field "desiredRuntimeVersion" on type "Deployment"

🎟 Issue(s)

Related https://github.com/astronomer/issues/issues/8180

🧪 Functional Testing

  1. Connect to a Houston instance running the updated schema (version ~1.0.1+)
  2. Run astro deploy and select a deployment
  3. Verify the deploy completes successfully without schema errors
  4. Run astro deployment list and verify deployments are listed correctly
  5. Run astro deployment create and verify creation works

Debug verification:

astro deploy --verbosity=debug

Should no longer show Cannot query field errors.

📸 Screenshots

Add screenshots showing successful deploy output or CLI debug logs.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@Simpcyclassy
Add Houston API 1.1.0 support - remove desiredRuntimeVersion and AC f…
c9b68a3 
…ields

- Add version 1.1.0 queries for DeploymentGetRequest
- Add version 1.1.0 queries for DeploymentsGetRequest
- Add version 1.1.0 queries for PaginatedDeploymentsGetRequest
- Add version 1.1.0 mutations for DeploymentCreateRequest
- Add version 1.1.0 mutations for DeploymentUpdateRequest
- Remove airflowVersion, desiredAirflowVersion, desiredRuntimeVersion fields
- Use runtimeVersion and runtimeAirflowVersion instead

Houston API 1.1.0 no longer returns desired version and AC fields.
All version information is now managed through runtimeVersion.
@coveralls-official
Copy link

coveralls-official bot commented Nov 28, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 70d3f680-a3fe-49ce-8d01-817ce9a18f9d

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 33.132%
Totals Coverage Status
Change from base Build 23d6d326-ef83-487f-9901-f16bd900b13d: 0.0%
Covered Lines: 20844
Relevant Lines: 62912
💛 - Coveralls

@karankhanchandani
Copy link

karankhanchandani commented Dec 12, 2025

@Simpcyclassy The desiredRuntime version changes are merged in houston and is currently breaking the CLI. Is it possible to merge this PR soon?

@Simpcyclassy
Copy link
Member Author

Simpcyclassy commented Dec 12, 2025

Yes, I can prioritise this today

@Simpcyclassy Simpcyclassy changed the title Add Houston API 1.1.0 support - remove desiredRuntimeVersion and AC fields Add Houston API 1.0.1 support - remove desiredRuntimeVersion and AC fields Dec 12, 2025
@Simpcyclassy Simpcyclassy marked this pull request as ready for review December 12, 2025 15:30
danielhoherd
danielhoherd approved these changes Dec 12, 2025
View reviewed changes
Copy link
Member

@danielhoherd danielhoherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, but do we need to update any tests for this?

@Simpcyclassy
Copy link
Member Author

Simpcyclassy commented Dec 14, 2025 •
edited
Loading

No we do not test the query string

@neel-astro neel-astro merged commit 0da8d52 into main Dec 15, 2025
5 of 6 checks passed
@neel-astro neel-astro deleted the houston-api-1.1.0-support branch December 15, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielhoherd danielhoherd danielhoherd approved these changes

@neel-astro neel-astro neel-astro approved these changes

@jeremybeard jeremybeard Awaiting requested review from jeremybeard

@kushalmalani kushalmalani Awaiting requested review from kushalmalani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Simpcyclassy @karankhanchandani @danielhoherd @neel-astro @pgvishnuram