Conversation
Pull Request Test Coverage Report for Build 500c460f-4dde-4c77-8b5a-e7bb50a8f16dDetails
💛 - Coveralls |
Prevent deployment of client images with runtime versions newer than the target deployment's runtime version to ensure compatibility. Changes: - Add --deployment-id flag to 'astro remote deploy' command for validation - Implement validateClientImageRuntimeVersion() function that: - Fetches deployment runtime version from platform API - Parses Dockerfile.client to extract client image runtime version - Rejects deployment if client version > deployment version - Enhance ParseImageTag() function to extract runtime versions from image tags like '3.1-1-python-3.12-astro-agent-1.1.0' - Add comprehensive test coverage for all validation scenarios - Update docker parsing to support Dockerfile.client files This ensures client images are compatible with the deployment environment and prevents runtime incompatibility issues.
f2ce526 to
3f78af2
Compare
neel-astro
approved these changes
Nov 20, 2025
Contributor
neel-astro
left a comment
There was a problem hiding this comment.
Left some tiny nits, but otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent deployment of client images with runtime versions newer than the target deployment's runtime version to ensure compatibility.
Changes:
This ensures client images are compatible with the deployment environment and prevents runtime incompatibility issues.
🎟 Issue(s)
closes: #1957
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft