Skip to content

Comments

Allow importing IDE projects to non-empty directories with user confirmation#1981

Merged
pritt20 merged 1 commit intorelease-1.38from
fix_ide_import_cherry_pick
Nov 3, 2025
Merged

Allow importing IDE projects to non-empty directories with user confirmation#1981
pritt20 merged 1 commit intorelease-1.38from
fix_ide_import_cherry_pick

Conversation

@pritt20
Copy link
Contributor

@pritt20 pritt20 commented Nov 3, 2025

Description

Previously, the astro ide project import command would fail if run in a non-empty directory, forcing users to create a new empty directory first. This change makes the experience more flexible by prompting users for confirmation before proceeding.

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

Tested the change on locally:

~ astro ide project import
Current directory is not empty. Do you want to import the project here? /tmp/test (y/n) y
Only one Project was found. Using the following Project by default: 

 Project Name: test
 Project ID: cmhevveiz010501nlj05z8t8o

Successfully exported project from cmhevveiz010501nlj05z8t8o
~ astro ide project import
Current directory is not empty. Do you want to import the project here? /tmp/test/dags (y/n) n
Error: import canceled by user

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 576c7367-0c8c-4d48-a185-3a0370efd1d1

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 38.64%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cloud/ide/project.go 0 5 0.0%
Totals Coverage Status
Change from base Build e36d2acb-25ef-4f1d-a6e5-4b336f15ff18: -0.001%
Covered Lines: 24283
Relevant Lines: 62845

💛 - Coveralls

@pritt20 pritt20 merged commit 7d0fde5 into release-1.38 Nov 3, 2025
3 of 6 checks passed
@pritt20 pritt20 deleted the fix_ide_import_cherry_pick branch November 3, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants