Conversation
feluelle
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
Pull Request Test Coverage Report for Build 7f0a7e15-2c91-4ca8-996e-c2ca3b027c45Details
💛 - Coveralls |
neel-astro
reviewed
Nov 3, 2025
Contributor
neel-astro
left a comment
neel-astro
left a comment
There was a problem hiding this comment.
Left some tiny comments to squash, but otherwise LGTM
feluelle
force-pushed
the
fix/remote-deploy-dependency-install
branch
2 times, most recently
from
890a225 to
c46e916
Compare
feluelle
force-pushed
the
fix/remote-deploy-dependency-install
branch
from
c46e916 to
8323649
Compare
- Introduced `ClientBuildContext` to manage temporary build directories for client deployments. - Implemented `prepareClientBuildContext` to create a build context without modifying original project files. - Added `setupClientDependencyFiles` to handle client-specific dependency files. - Updated `DeployClientImage` to utilize the new build context for image building. - Enhanced tests to cover new functionality and ensure proper handling of client dependency files.
feluelle
force-pushed
the
fix/remote-deploy-dependency-install
branch
from
8323649 to
9f0b14c
Compare
feluelle
added a commit
that referenced
this pull request
Nov 3, 2025
…tallation during image build (#1980)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes the issue in the
astro remote deploycommand, where it does not consider therequirements-client.txtandpackages-client.txtfiles for dependency installation into the image.🎟 Issue(s)
Fixes: #1979
🧪 Functional Testing
Validated that the dependencies get installed correctly from client files:
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft