Skip to content

Comments

Improve remote deploy messaging#1970

Merged
neel-astro merged 4 commits intomainfrom
improve-remote-deploy-msg
Oct 24, 2025
Merged

Improve remote deploy messaging#1970
neel-astro merged 4 commits intomainfrom
improve-remote-deploy-msg

Conversation

@neel-astro
Copy link
Contributor

@neel-astro neel-astro commented Oct 24, 2025

Description

Changes:

  • Improve remote deploy messaging to be more descriptive and helpful
  • Add tiny logic to skip login to Astronomer if the base image in the Dockerfile.client is not from the Astronomer registry
  • Add logic to pick the best available client image when the runtime version is passed
  • Bump the default timeout for deployment create wait time to 10 mins, since there are a decent number of times when deployment create takes slightly more than 5 mins
  • Set the remote base image registry as the image host in Dockerfile.client
  • Fix issue around deployment health poll failing for deployment that hibernates right after creation

🎟 Issue(s)

https://astronomer.slack.com/archives/C07FWJXBQ3X/p1761225561411039

🧪 Functional Testing

image image image image image

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@coveralls-official
Copy link

coveralls-official bot commented Oct 24, 2025

Pull Request Test Coverage Report for Build 2e3d4ea8-8696-45f6-980d-26ef38dfe1e3

Details

  • 81 of 90 (90.0%) changed or added relevant lines in 8 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 38.57%

Changes Missing Coverage Covered Lines Changed/Added Lines %
airflow/docker_image.go 5 7 71.43%
airflow_versions/airflow_versions.go 22 24 91.67%
cloud/deploy/deploy.go 31 36 86.11%
Files with Coverage Reduction New Missed Lines %
docker/docker.go 3 44.68%
Totals Coverage Status
Change from base Build e929ed65-8a53-4ab9-839c-cf8bad950067: 0.05%
Covered Lines: 24197
Relevant Lines: 62736

💛 - Coveralls

@neel-astro neel-astro requested a review from a team October 24, 2025 08:25
@neel-astro neel-astro merged commit b821a53 into main Oct 24, 2025
7 checks passed
@neel-astro neel-astro deleted the improve-remote-deploy-msg branch October 24, 2025 15:25
neel-astro added a commit that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants