Skip to content

Comments

Fix remote deploy push logic around figuring out registry from the endpoint#1966

Merged
neel-astro merged 1 commit intomainfrom
fix-remote-deploy
Oct 22, 2025
Merged

Fix remote deploy push logic around figuring out registry from the endpoint#1966
neel-astro merged 1 commit intomainfrom
fix-remote-deploy

Conversation

@neel-astro
Copy link
Contributor

Description

  • Fix the registry endpoint parse logic for remote registry, as they do not follow the standard for existing Astro registries.

Error that users were facing with AWS ECR:

astro remote deploy
Authenticated to Astro

Building client image for host platform
✔ Project image has been updated
Pushing client image to configured remote registry
Error: failed to push client image: internal logic error: unsure how to get registry from image name <registry endpoint>

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

image

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 60fdc93f-236c-4288-a100-8d55b93df937

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 38.511%

Totals Coverage Status
Change from base Build 11abc801-ce74-4385-820b-b7258edea6eb: 0.003%
Covered Lines: 24134
Relevant Lines: 62667

💛 - Coveralls

@neel-astro neel-astro requested a review from feluelle October 21, 2025 17:05
@neel-astro neel-astro merged commit 673aebb into main Oct 22, 2025
6 of 7 checks passed
@neel-astro neel-astro deleted the fix-remote-deploy branch October 22, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants