Skip to content

Comments

Add feature flag for new remote command#1956

Merged
feluelle merged 1 commit intomainfrom
feature/feature-flag-remote-command
Oct 10, 2025
Merged

Add feature flag for new remote command#1956
feluelle merged 1 commit intomainfrom
feature/feature-flag-remote-command

Conversation

@feluelle
Copy link
Member

@feluelle feluelle commented Oct 9, 2025

Description

Describe the purpose of this pull request.

This pull request introduces a new feature flag to conditionally enable the Remote command in the CLI. The flag is implemented as a configuration option and is used to control whether the Remote command is included in the available commands at runtime.

Feature flag addition and usage:

  • Added a new configuration option beta.remote_cmd (exposed as RemoteCmd in the config types) to enable or disable the Remote command. [1] [2]
  • Updated the command registration logic in cmd/cloud/root.go to append the Remote command only if the RemoteCmd config flag is set to true.
  • Imported the config package in cmd/cloud/root.go to access the new configuration flag.

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

❯ ./astro config set -g beta.remote_cmd false
Setting beta.remote_cmd to false successfully

❯ ./astro remote
Error: unknown command "remote" for "astro"
Run 'astro --help' for usage.

❯ ./astro config set -g beta.remote_cmd true
Setting beta.remote_cmd to true successfully

❯ ./astro remote
Commands for interacting with remote registries and deploying client images

Current Context: Astro

Usage:
  astro remote [command]

Available Commands:
  deploy      Deploy a client image to the remote registry

Flags:
  -h, --help   help for remote

Global Flags:
      --verbosity string   Log level (debug, info, warn, error, fatal, panic (default "warning")

Use "astro remote [command] --help" for more information about a command.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 9fc9a3e2-c0ee-4ebd-8ffe-3d3c6474e8f6

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 38.518%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/cloud/root.go 3 5 60.0%
Totals Coverage Status
Change from base Build 17118b72-6d1c-4f52-a8ad-1f625b419c1e: -0.001%
Covered Lines: 24139
Relevant Lines: 62669

💛 - Coveralls

@feluelle feluelle self-assigned this Oct 9, 2025
@feluelle feluelle merged commit 4b9c23b into main Oct 10, 2025
4 of 7 checks passed
@feluelle feluelle deleted the feature/feature-flag-remote-command branch October 10, 2025 09:43
neel-astro added a commit that referenced this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants