Add client deploy support for RE projects#1954
Merged
Conversation
Pull Request Test Coverage Report for Build daba1279-352d-4b3f-86b8-9669f3a12ad3Details
💛 - Coveralls |
36cafb4 to
46a7b12
Compare
neel-astro
reviewed
Oct 8, 2025
Contributor
neel-astro
left a comment
There was a problem hiding this comment.
Left a couple of comments, but otherwise the change is looking solid, thanks for putting this all together
46a7b12 to
4b53722
Compare
- add `--client` flag to deploy command - add `--platform` flag to deploy command
9a24bc3 to
5c0c81b
Compare
neel-astro
approved these changes
Oct 9, 2025
Contributor
neel-astro
left a comment
There was a problem hiding this comment.
Left some nits, but otherwise LGTM
feluelle
commented
Oct 9, 2025
2e63d4f to
0c6c054
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new "remote deploy" command to support building and pushing client images to a configurable remote registry, along with improvements to Docker authentication and extensive test coverage. The changes include a new command group, a new deploy workflow for client images, enhancements to Docker login for OAuth-based registries, and comprehensive tests for the new functionality.
Major features and improvements:
New Remote Deploy Command
remotecommand group with adeploysubcommand (cmd/cloud/remote.go) that allows users to build and deploy client images to a remote registry, supporting custom image names, platforms, and build secrets.Client Image Deployment Workflow
DeployClientImagefunction and supportingInputClientDeploystruct incloud/deploy/deploy.go, enabling image builds (with multi-platform support), tagging, and pushes to a configurable remote registry, with proper error handling and user feedback. [1] [2]Docker Authentication Enhancements
DockerLoginfunction inairflow/docker_registry.gothat performs Docker login using a shell command, supporting OAuth/Bearer tokens and integration with custom container runtimes. [1] [2]Testing Improvements
DeployClientImageworkflow, including scenarios for successful deploys, authentication failures, missing configuration, build failures, push failures, and custom image name handling (cloud/deploy/deploy_test.go).DockerLoginfunction, covering different credential and error scenarios (airflow/docker_registry_test.go).Dependency and Import Updates
These changes collectively enhance the CLI's ability to manage and deploy client images to remote registries, improve authentication support, and ensure robust test coverage for new workflows.
🎟 Issue(s)
closes: #1929
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft