Skip to content

Comments

Strip newline char from entries in dag integrity exceptions#1951

Merged
neel-astro merged 2 commits intoastronomer:mainfrom
THEdavehogue:issue-1950/dag-integrity-exceptions-fix
Nov 20, 2025
Merged

Strip newline char from entries in dag integrity exceptions#1951
neel-astro merged 2 commits intoastronomer:mainfrom
THEdavehogue:issue-1950/dag-integrity-exceptions-fix

Conversation

@THEdavehogue
Copy link
Contributor

@THEdavehogue THEdavehogue commented Oct 7, 2025

Description

Describe the purpose of this pull request.

Adds a .strip() to each item in the dag_integrity_exceptions.txt file when read by the astro dev parse command and test functions

🎟 Issue(s)

Related #1950

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

Was able to test this locally in my astro project. Adding the .strip() for each item in the exceptions list resolved the issue where the files listed would still raise errors.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

Before fix (with errors):
Screenshot 2025-10-07 at 10 35 30 AM

After fix (errors resolved):
Screenshot 2025-10-07 at 10 35 14 AM

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@THEdavehogue THEdavehogue marked this pull request as ready for review October 7, 2025 16:43
@neel-astro neel-astro merged commit 1004480 into astronomer:main Nov 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants