Skip to content

Comments

[Fix]: per deployment docker login#1945

Merged
ianbuss merged 20 commits intomainfrom
feat/fix-perdb-registry-login
Oct 8, 2025
Merged

[Fix]: per deployment docker login#1945
ianbuss merged 20 commits intomainfrom
feat/fix-perdb-registry-login

Conversation

@pgvishnuram
Copy link
Contributor

@pgvishnuram pgvishnuram commented Sep 26, 2025 •
edited by rishkarajgi
Loading

Description

Describe the purpose of this pull request.

🎟 Issue(s)

https://github.com/astronomer/issues/issues/7903
https://github.com/astronomer/issues/issues/7944

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@pgvishnuram pgvishnuram changed the title fix docker login [Fix]: per deployment docker login Oct 3, 2025
ianbuss
ianbuss reviewed Oct 3, 2025
View reviewed changes
ianbuss
ianbuss approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@ianbuss ianbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with nit.

@ianbuss
Copy link
Contributor

ianbuss commented Oct 3, 2025

Approved with nit.

Any tests need updating/adding?

@coveralls-official
Copy link

coveralls-official bot commented Oct 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 1ecdcaa8-dbb0-4ff9-8063-ec1ef1285613

Details

  • 23 of 23 (100.0%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 38.294%
Files with Coverage Reduction New Missed Lines %
software/deploy/deploy.go 1 89.35%
docker/docker.go 2 46.81%
Totals Coverage Status
Change from base Build 749c30b6-5e3d-48ab-9e7d-a8679049ec15: 0.02%
Covered Lines: 23892
Relevant Lines: 62391
💛 - Coveralls

@pgvishnuram pgvishnuram marked this pull request as ready for review October 3, 2025 20:05
ianbuss
ianbuss reviewed Oct 3, 2025
View reviewed changes
neel-astro
neel-astro reviewed Oct 6, 2025
View reviewed changes
@ianbuss ianbuss merged commit 5df292b into main Oct 8, 2025
7 checks passed
@ianbuss ianbuss deleted the feat/fix-perdb-registry-login branch October 8, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianbuss ianbuss ianbuss approved these changes

@neel-astro neel-astro neel-astro left review comments

@karankhanchandani karankhanchandani Awaiting requested review from karankhanchandani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pgvishnuram @ianbuss @neel-astro