Update Astro IDE export command to fetch project url from API#1943
Merged
Update Astro IDE export command to fetch project url from API#1943
Conversation
pritt20
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
Pull Request Test Coverage Report for Build 75959dbb-ffb5-4695-8d84-ed1fd01d8754Details
💛 - Coveralls |
jeremybeard
reviewed
Sep 25, 2025
cloud/ide/project.go
Outdated
| if err == nil && projectResp != nil && projectResp.JSON200 != nil && projectResp.JSON200.Url != nil && *projectResp.JSON200.Url != "" { | ||
| url = *projectResp.JSON200.Url | ||
| } else { | ||
| // Fallback to constructing the URL if API URL is unavailable |
Contributor
There was a problem hiding this comment.
I'd prefer we just not open the project in the browser if we can't get an URL, or we still run the risk of sending the user to a stale URL.
jeremybeard
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes update Astro IDE export command to fetch project url from API and if it fails to do so, we fallback to constructing the project url at Astro CLI level.
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
Tested the change locally and Astro CLI was able to fetch the project url from API as expected.
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft