fix-1909: handle default_pool updates with slots/include_deferred mask#1940
Merged
neel-astro merged 4 commits intomainfrom Oct 8, 2025
Merged
fix-1909: handle default_pool updates with slots/include_deferred mask#1940neel-astro merged 4 commits intomainfrom
neel-astro merged 4 commits intomainfrom
Conversation
bmanan7
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
neel-astro
reviewed
Sep 18, 2025
airflow-client/airflow-client.go
Outdated
Comment on lines
188
to
194
| payload = struct { | ||
| Slots int `json:"slots"` | ||
| IncludeDeferred bool `json:"include_deferred"` | ||
| }{ | ||
| Slots: pool.Slots, | ||
| IncludeDeferred: pool.IncludeDeferred, | ||
| } |
Contributor
There was a problem hiding this comment.
Correct me if I am wrong, but based on the airflow code, I think you just need to pass the update_mask in the path param for the default pool. So no need to exclusively send these two fields, airflow will take care of selecting these two fields from the request body based on the update_mask path param
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion. You’re right. Airflow handler only enforces that update_mask is supplied and constrained, it doesn’t object to extra fields in the body. I have updated code to keep it straight forward i.e just appending update_mask=slots&update_mask=include_deferred when the pool name is default_pool.
Pull Request Test Coverage Report for Build 89426d4e-e43d-4bd5-8b00-098a46c6d25fDetails
💛 - Coveralls |
bmanan7
force-pushed
the
bugfix/1909-handle-default-pool
branch
from
af5fa62 to
87e2374
Compare
neel-astro
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
default_poolPATCH rules: send onlyslotsandinclude_deferredwith an update_mask.🎟 Issue(s)
Related #1909
🧪 Functional Testing
Tried copying pool with different slot values and number of pools and each request was successful. Attached screenshots from UI.
📸 Screenshots
Confirmed from UI that the default pool slot value is being updated and reflected without any errors.
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft