improve the dag server upload url flow#1926
Merged
pgvishnuram merged 8 commits intomainfrom Sep 2, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build ba408fae-39f6-4e8b-8280-d66e248b3e14Details
💛 - Coveralls |
pgvishnuram
commented
Aug 31, 2025
pgvishnuram
changed the title
ianbuss
reviewed
Sep 1, 2025
pgvishnuram
requested review from
jeremybeard,
karankhanchandani,
kushalmalani and
neel-astro
as code owners
pgvishnuram
commented
Sep 2, 2025
Comment on lines
+424
to
+426
| if url.Type != houston.AirflowURLType { | ||
| continue | ||
| } |
Contributor
Author
There was a problem hiding this comment.
initially i added url.Type == houston.AirflowURLType
then start generating the urls
revive was recommending similar changes what i added currently
rujhan-arora-astronomer
approved these changes
Sep 2, 2025
ianbuss
approved these changes
Sep 2, 2025
Contributor
ianbuss
left a comment
ianbuss
left a comment
There was a problem hiding this comment.
Looks ok to me. Left a nit.
Shubham-astro
approved these changes
Sep 2, 2025
ianbuss
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously dag upload URL's were harded to fetch from the baseDomain, this will no longer work with 1.0 api and with this new change we look for dagserver url directly and if not exists it will reconstruct the url from airflow url in order to handle both old api version and new code changes
🎟 Issue(s)
🧪 Functional Testing
There is no change from the user prespective
astro deploy --dags will auto detect and use the upload url for respective clustered deployments
📸 Screenshots
with above code changes it auto detects the url from deployments without needing to use hardcoded base domain from the config
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft