Removed create and update deployment and replaced with upsert deployment#1915
Merged
pgvishnuram merged 3 commits intomainfrom Aug 20, 2025
Merged
Removed create and update deployment and replaced with upsert deployment#1915pgvishnuram merged 3 commits intomainfrom
pgvishnuram merged 3 commits intomainfrom
Conversation
rujhan-arora-astronomer
requested review from
jeremybeard,
karankhanchandani,
kushalmalani,
neel-astro and
pgvishnuram
as code owners
Contributor
|
for airflow3 software now enforces dagProcessor we should them as well |
pgvishnuram
approved these changes
Aug 20, 2025
| // UpdateDeployment - update a deployment | ||
| func (h ClientImplementation) UpdateDeployment(variables map[string]interface{}) (*Deployment, error) { | ||
| reqQuery := DeploymentUpdateRequest.GreatestLowerBound(version) | ||
| if variables["payload"] != nil { |
There was a problem hiding this comment.
Is it possible for you to add test for this if statement?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed create and update deployment and replaced with upsert deployment. This is only for Software versions >= 1.0.0.
For older Software versions, CLI would use the existing create and update flows.
🎟 Issue(s)
Related https://github.com/astronomer/issues/issues/7570
🧪 Functional Testing
Locally
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft