Skip to content

Comments

Added the support for clusterID for the runtime releases flows in CLI#1906

Merged
neel-astro merged 5 commits intomainfrom
gh_7572
Aug 12, 2025
Merged

Added the support for clusterID for the runtime releases flows in CLI#1906
neel-astro merged 5 commits intomainfrom
gh_7572

Conversation

@rujhan-arora-astronomer
Copy link
Contributor

@rujhan-arora-astronomer rujhan-arora-astronomer commented Jul 31, 2025

Description

Currently, the CLI fetches the list of available Runtime versions and applies filters based on the Houston configmap. This approach is problematic for 1.0 because it doesn't account for feature flags or specific configurations that may be enabled on a per-cluster basis.

As a result, a user might see a list of Runtimes that is not accurate for their target environment. For example, a cluster with a feature flag enabled for Airflow 3 would not see it in the list of available versions if it is disabled at the global level, preventing them from using it.
This PR resolves this issue by ensuring that whenever the CLI requests a list of available Runtime versions, it passes the relevant clusterId ID. The backend API can then use this ID to evaluate cluster-specific feature flags and return a precise, filtered list of Runtimes that are actually available for that cluster.

🎟 Issue(s)

Related 7572(https://github.com/astronomer/issues/issues/7572)

🧪 Functional Testing

Tested locally
Unit tests

📸 Screenshots

Screenshot 2025-07-31 at 1 30 42 PM Screenshot 2025-07-31 at 1 30 18 PM Screenshot 2025-07-31 at 1 29 58 PM Screenshot 2025-07-31 at 1 18 30 PM Screenshot 2025-07-31 at 1 11 54 PM Screenshot 2025-07-31 at 1 11 19 PM

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link
Contributor

@rishkarajgi rishkarajgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@karankhanchandani karankhanchandani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM.

…in CLI (#1907)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@neel-astro neel-astro merged commit 4e4191f into main Aug 12, 2025
4 of 5 checks passed
@neel-astro neel-astro deleted the gh_7572 branch August 12, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants