Skip to content

Comments

Validate --remote-execution-enabled field on deployment creation#1896

Merged
feluelle merged 1 commit intomainfrom
remote-execution-validation
Jul 18, 2025
Merged

Validate --remote-execution-enabled field on deployment creation#1896
feluelle merged 1 commit intomainfrom
remote-execution-validation

Conversation

@feluelle
Copy link
Member

@feluelle feluelle commented Jul 18, 2025

Description

Describe the purpose of this pull request.

When the user creates a deployment with the --remote-execution-enabled flag, we only use that for dedicated deployment requests and silently ignore the flag for standard Deployments. This is poor UX, and we should validate that this flag is not being passed if the type is not dedicated.

🎟 Issue(s)

closes: #1895

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@feluelle feluelle force-pushed the remote-execution-validation branch from a6fc7b1 to 442c326 Compare July 18, 2025 11:14
Copy link
Contributor

@ianbuss ianbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feluelle feluelle merged commit 8a9f8fc into main Jul 18, 2025
4 of 5 checks passed
@feluelle feluelle deleted the remote-execution-validation branch July 18, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--remote-execution-enabled flag creates standard deployment instead of failing or prompting for required config

2 participants