Skip to content

Comments

Fix create/update deployment from file not respecting astro executor for standard deployments#1892

Merged
neel-astro merged 1 commit intomainfrom
fix/standarddeployment-from-file-astro-executor
Jul 11, 2025
Merged

Fix create/update deployment from file not respecting astro executor for standard deployments#1892
neel-astro merged 1 commit intomainfrom
fix/standarddeployment-from-file-astro-executor

Conversation

@feluelle
Copy link
Member

Description

Describe the purpose of this pull request.

Currently, when trying to create a standard deployment from a file using Astro executor, we get:

Error: Missing fields: executor

because it is not being added to the request payload. This PR adds that field to standard deployment creation and update requests.

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@feluelle feluelle requested a review from a team July 11, 2025 10:19
@neel-astro neel-astro merged commit af4d2b0 into main Jul 11, 2025
4 of 5 checks passed
@neel-astro neel-astro deleted the fix/standarddeployment-from-file-astro-executor branch July 11, 2025 10:22
neel-astro pushed a commit that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants