Update the deployment detail URL to match change in Cloud UI#1890
Merged
neel-astro merged 1 commit intomainfrom Jul 7, 2025
Merged
Update the deployment detail URL to match change in Cloud UI#1890neel-astro merged 1 commit intomainfrom
neel-astro merged 1 commit intomainfrom
Conversation
ryanahamilton
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
neel-astro
approved these changes
Jul 7, 2025
Contributor
neel-astro
left a comment
neel-astro
left a comment
There was a problem hiding this comment.
Thanks for the fix ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the output links to the Cloud UI Deployment from
/:workspaceId/deployments/:deploymentId/overviewto/:workspaceId/deployments/:deploymentIdas a result of this changing in https://github.com/astronomer/astro/pull/32302. This change does maintain compatibility with the old/existing URLs used by current CLI versions.Updated tests accordingly.
This change is almost identical to a previous change I made to CLI in #1378 a couple of years ago.
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft