Skip to content

Comments

Fix standard deployment worker queue updates#1889

Merged
feluelle merged 1 commit intomainfrom
fixup-standard-wq-on-update
Jul 3, 2025
Merged

Fix standard deployment worker queue updates#1889
feluelle merged 1 commit intomainfrom
fixup-standard-wq-on-update

Conversation

@jaketf
Copy link
Contributor

@jaketf jaketf commented Jul 2, 2025 •
edited by feluelle
Loading

Description

Describe the purpose of this pull request.

Add the missing worker queues setting on the standard deployment request, which is used as input to convert the worker queues. Since it was always empty, it used the default working queue.

🎟 Issue(s)

https://astronomer.slack.com/archives/C094HLLJ7LG/p1751456555675199?thread_ts=1751379015.279859&cid=C094HLLJ7LG

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

❯ ./astro deployment inspect
Select a Deployment
 #     DEPLOYMENT NAME     RELEASE NAME             DEPLOYMENT ID                 DAG DEPLOY ENABLED     
 1     test                dynamical-light-7996     cmcnmomkv03d201kkqlytrnys     true                   

> 1
deployment:
    ...
    worker_queues:
        - name: default
          min_worker_count: 0
          worker_type: A5
          pod_cpu: "1"
          pod_ram: 2Gi
        - name: foo
          min_worker_count: 0
          worker_type: A5
          pod_cpu: "1"
          pod_ram: 2Gi

❯ ./astro deployment update
Select a Deployment
 #     DEPLOYMENT NAME     RELEASE NAME             DEPLOYMENT ID                 DAG DEPLOY ENABLED     
 1     test                dynamical-light-7996     cmcnmomkv03d201kkqlytrnys     true                   

> 1
 NAME     NAMESPACE                CLUSTER     CLOUD PROVIDER     REGION        DEPLOYMENT ID                 RUNTIME VERSION                    DAG DEPLOY ENABLED     CI-CD ENFORCEMENT     DEPLOYMENT TYPE     
 test     dynamical-light-7996     N/A         AWS                us-east-1     cmcnmomkv03d201kkqlytrnys     3.0-4 (based on Airflow 3.0.2)     true                   false                 STANDARD            

 Successfully updated Deployment

❯ ./astro deployment inspect
Select a Deployment
 #     DEPLOYMENT NAME     RELEASE NAME             DEPLOYMENT ID                 DAG DEPLOY ENABLED     
 1     test                dynamical-light-7996     cmcnmomkv03d201kkqlytrnys     true                   

> 1
deployment:
    ...
    worker_queues:
        - name: default
          min_worker_count: 0
          worker_type: A5
          pod_cpu: "1"
          pod_ram: 2Gi
        - name: foo
          min_worker_count: 0
          worker_type: A5
          pod_cpu: "1"
          pod_ram: 2Gi
...

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@jaketf jaketf requested a review from feluelle July 2, 2025 21:33
@feluelle feluelle force-pushed the fixup-standard-wq-on-update branch from 47878c2 to 100577f Compare July 3, 2025 16:51
@feluelle feluelle changed the title fix standard worker queue updates Fix standard worker queue updates Jul 3, 2025
@feluelle feluelle changed the title Fix standard worker queue updates Fix standard deployment worker queue updates Jul 3, 2025
@feluelle feluelle self-assigned this Jul 3, 2025
@feluelle feluelle marked this pull request as ready for review July 3, 2025 17:01
@feluelle feluelle merged commit 3002d26 into main Jul 3, 2025
4 of 5 checks passed
@feluelle feluelle deleted the fixup-standard-wq-on-update branch July 3, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neel-astro neel-astro neel-astro approved these changes

@feluelle feluelle Awaiting requested review from feluelle

@jeremybeard jeremybeard Awaiting requested review from jeremybeard

@kushalmalani kushalmalani Awaiting requested review from kushalmalani

Assignees

@jaketf jaketf

@feluelle feluelle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaketf @neel-astro @feluelle