Skip to content

Comments

remove AF 3 block for astro variable create | list | update#1888

Merged
jaketf merged 4 commits intomainfrom
astro-variable
Jul 2, 2025
Merged

remove AF 3 block for astro variable create | list | update#1888
jaketf merged 4 commits intomainfrom
astro-variable

Conversation

@jaketf
Copy link
Contributor

@jaketf jaketf commented Jul 1, 2025

Description

Describe the purpose of this pull request.

remove AF 3 block for astro variable [create | update | list]

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

jake@Jakes-MacBook-Pro astro-cli % ./astro deployment variable create -n test-astro-exec-from-cli hey=jake
adding variable hey

Updated list of your Deployment's variables:
 #     KEY                 VALUE     SECRET     
 1     AIRFLOW_VAR_FOO     bar       false      
 2     hey                 jake      false      
jake@Jakes-MacBook-Pro astro-cli % ./astro deployment variable list -n test-astro-exec-from-cli         
 #     KEY                 VALUE     SECRET     
 1     AIRFLOW_VAR_FOO     bar       false      
 2     hey                 jake      false      
jake@Jakes-MacBook-Pro astro-cli % ./astro deployment variable update -n test-astro-exec-from-cli hey=felix
updating variable hey 

Updated list of your Deployment's variables:
 #     KEY                 VALUE     SECRET     
 1     AIRFLOW_VAR_FOO     bar       false      
 2     hey                 felix     false

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@jaketf
Copy link
Contributor Author

jaketf commented Jul 1, 2025

@yanmastin-astro @lzdanski this PR will remove the AF 3 block for astro deployment variable create | list | update in upcoming v1.36.0

@jaketf jaketf requested a review from feluelle July 1, 2025 18:47
@jaketf jaketf changed the title Astro variable remove AF 3 block for astro variable create | list | update Jul 1, 2025
feluelle
feluelle approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey jake :)

@jaketf jaketf merged commit bbb94b3 into main Jul 2, 2025
4 of 5 checks passed
@jaketf jaketf deleted the astro-variable branch July 2, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feluelle feluelle feluelle approved these changes

@neel-astro neel-astro Awaiting requested review from neel-astro

@jeremybeard jeremybeard Awaiting requested review from jeremybeard

@kushalmalani kushalmalani Awaiting requested review from kushalmalani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaketf @feluelle