Conversation
jaketf
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
ianbuss
reviewed
Jun 25, 2025
Contributor
ianbuss
left a comment
ianbuss
left a comment
There was a problem hiding this comment.
Couple of small comments.
go.mod
Outdated
| go 1.23.0 | ||
|
|
||
| // toolchain go1.24.1 | ||
| toolchain go1.24.1 |
Contributor
There was a problem hiding this comment.
Do we need this toolchain entry? Should we just update the go version to 1.24?
Contributor
Author
There was a problem hiding this comment.
good question.
I have issues when this line is present when using debugger in IDE.
I have had issues in the past when this line is missing when running make fmt (gofumpt under the hood).
Contributor
Author
There was a problem hiding this comment.
I'll remove it for now and see if anything breaks in CI
Contributor
There was a problem hiding this comment.
I don't consider it blocking but it would be nice for the values to agree I guess? Anyway, approving as it is commented in main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
astro deployment logs🎟 Issue(s)
fixes #1877
🧪 Functional Testing
https://astronomer.slack.com/archives/C07FWJXBQ3X/p1750789166767639
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft