Support deploy command for Remote Execution Deployments#1875
Conversation
feluelle
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
feluelle
force-pushed
the
feature/remote-exec-deploy
branch
from
5d83f0f to
c3df58b
Compare
| DefaultTaskPodMemory: deploymentFromFile.Deployment.Configuration.DefaultTaskPodMemory, | ||
| ResourceQuotaCpu: deploymentFromFile.Deployment.Configuration.ResourceQuotaCPU, | ||
| ResourceQuotaMemory: deploymentFromFile.Deployment.Configuration.ResourceQuotaMemory, | ||
| DefaultTaskPodCpu: &deploymentFromFile.Deployment.Configuration.DefaultTaskPodCPU, |
There was a problem hiding this comment.
It seems we need to add a new optional block for the deployment file to configure remote execution can you add that, test it and communicate with @yanmastin-astro re: docs changes to https://www.astronomer.io/docs/astro/deployment-file-reference/
There was a problem hiding this comment.
from_file is part of deployment create/update, hence you can find it in #1874
ianbuss
left a comment
ianbuss
left a comment
There was a problem hiding this comment.
Looks straightforward to me. Left a small question about the auto-generated API changes.
| CreateEnvironmentObjectLinkRequestScopeDEPLOYMENT CreateEnvironmentObjectLinkRequestScope = "DEPLOYMENT" | ||
| ) | ||
|
|
||
| // Defines values for CreateEnvironmentObjectMetricsExportOverridesRequestAuthType. |
There was a problem hiding this comment.
The updates in this file seem all unrelated to remote execution and its enablement?
There was a problem hiding this comment.
I guess came along for the ride for free when we updated platform-core?
There was a problem hiding this comment.
Correct. I have generated it from the release branch that targeted the v1beta1 platform support.
3 participants
Description
This is to support the Remote Execution configuration for Astro Executor Deploys in the CLI.
🎟 Issue(s)
closes: https://github.com/astronomer/astro/issues/29376
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft