Skip to content

Comments

Add remote execution config to deployment create/update/inspect commands#1874

Merged
feluelle merged 3 commits intomainfrom
feature/deployment-create-update-args-remote-execution
Jun 25, 2025
Merged

Add remote execution config to deployment create/update/inspect commands#1874
feluelle merged 3 commits intomainfrom
feature/deployment-create-update-args-remote-execution

Conversation

@feluelle
Copy link
Member

@feluelle feluelle commented Jun 24, 2025 •
edited
Loading

Description

Describe the purpose of this pull request.

This is to support the Remote Execution configuration for Astro Executor Deployments in the CLI.

🎟 Issue(s)

closes: #1853

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@feluelle feluelle requested review from jaketf and removed request for jeremybeard, kushalmalani and neel-astro June 24, 2025 12:17
@feluelle feluelle force-pushed the feature/deployment-create-update-args-remote-execution branch 2 times, most recently from b43e5ab to 11ce104 Compare June 24, 2025 15:34
@feluelle feluelle requested review from a team and neel-astro June 24, 2025 15:48
jaketf
jaketf reviewed Jun 24, 2025
View reviewed changes
Copy link
Contributor

@jaketf jaketf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question about option log args on create

@feluelle feluelle mentioned this pull request Jun 25, 2025
Merged
8 tasks
@feluelle feluelle requested a review from jaketf June 25, 2025 10:33
ianbuss
ianbuss reviewed Jun 25, 2025
View reviewed changes
Copy link
Contributor

@ianbuss ianbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, otherwise looks straightforward.

@feluelle feluelle force-pushed the feature/deployment-create-update-args-remote-execution branch from 04756a7 to 2b0845f Compare June 25, 2025 12:24
@feluelle feluelle requested a review from ianbuss June 25, 2025 12:24
@feluelle feluelle merged commit e49ac9b into main Jun 25, 2025
4 of 5 checks passed
@feluelle feluelle deleted the feature/deployment-create-update-args-remote-execution branch June 25, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaketf jaketf jaketf approved these changes

@neel-astro neel-astro Awaiting requested review from neel-astro

@ianbuss ianbuss Awaiting requested review from ianbuss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add remote execution config to deployment create/update/inspect commands

3 participants

@feluelle @ianbuss @jaketf