Support AF3 connections, variables and pools CLU#1869
Conversation
- update airflow client to be api version agnostic - use metadata airflow api url for airflow client - add include_deferred to airflow client pool schema - add include-deferred cli flag to pool create - add include-deferred cli flag to pool update as it is required for AF3 - show include deferred in pool listing
898d618 to
8af4029
Compare
jaketf
left a comment
There was a problem hiding this comment.
quick work on this one thanks!
|
@feluelle I do think we'll need to update the docs to reflect this new support. |
Update the issue or PR with any details that we need to add in the docs. While creating the pre-release we should collect all the issues or PRs being added in the release and share it with Yan to help with the docs changes. |
neel-astro
left a comment
There was a problem hiding this comment.
Left a comment, functionally looks ok otherwise
Description
Support AF3 connections, variables and pools CLU
Note
This PR removes support for pools CLU (Create, List, and Update) in Airflow Versions 2.6 and below. Airflow 2.6 corresponds to Runtime Version 8, which has reached End of maintenance date and is close to reaching
End of basic support(see also Basic Support).🎟 Issue(s)
closes: #1867
🧪 Functional Testing
📸 Screenshots
Connections
AF2
AF3
Variables
AF2
AF3
Pools
AF2
AF3
AF2.6
❯ ./astro deployment pool create -d cmbuzidah01c501m1qy7vtp2t --name foo --slots 1 Creating pool foo Error: API error (400): { "detail": "{'include_deferred': ['Unknown field.']}", "status": 400, "title": "Bad Request", "type": "http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow/latest/stable-rest-api-ref.html#section/Errors/BadRequest" } ❯ ./astro deployment pool update -d cmbuzidah01c501m1qy7vtp2t --name foo --slots 1 updating pool foo Error: API error (400): { "detail": "{'include_deferred': ['Unknown field.']}", "status": 400, "title": "Bad Request", "type": "http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow/latest/stable-rest-api-ref.html#section/Errors/BadRequest" }📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft