Merged
Conversation
jaketf
requested review from
jeremybeard,
kushalmalani,
lzdanski and
neel-astro
as code owners
jeremybeard
approved these changes
May 22, 2025
| } | ||
|
|
||
| err := handler.Login("", "") | ||
| err := handler.Login("testuser", "testtoken") |
Contributor
There was a problem hiding this comment.
Thanks for fixing this and in another unrelated test. I thought I'd fixed these but they're still sitting in an open PR.
|
|
||
| func ListConnections(workspaceID, deploymentID string, coreClient astrocore.CoreClient) (map[string]astrocore.EnvironmentObjectConnection, error) { | ||
| envObjs, err := listEnvironmentObjects(workspaceID, deploymentID, astrocore.ListEnvironmentObjectsParamsObjectTypeCONNECTION, coreClient) | ||
| envObjs, err := listEnvironmentObjects(workspaceID, deploymentID, astrocore.CONNECTION, coreClient) |
Contributor
There was a problem hiding this comment.
It's bizarre how this new client gen version removes the prefixes from some enums but adds them to others 😕
neel-astro
pushed a commit
that referenced
this pull request
May 26, 2025
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In prep for AF Programmatic support, this regenerates the core clients moving off the deprecated deepmap oapi-generator to it's new v2 import paths.
we'll likely need to regen these again after adding Astro executor / remote execution support to the upstream APIs. The hope of this PR is to make those later PRs go smoother.
🎟 Issue(s)
Related #1854
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft