Pull latest Ruff image on upgrade-test#1843
Merged
jeremybeard merged 1 commit intomainfrom Apr 23, 2025
Merged
Conversation
neel-astro
approved these changes
Apr 23, 2025
| @@ -432,6 +432,10 @@ func (d *DockerImage) getRegistryToAuth(imageName string) (string, error) { | |||
| } | |||
|
|
|||
| func (d *DockerImage) Pull(remoteImage, username, token string) error { | |||
Contributor
There was a problem hiding this comment.
this method feels slightly wrong to me right now. Mostly I had written it or reviewed it sometime in the past 🙈 . But thinking about it now, why do we even have two separate ways to pass image name?
This is not a blocker at all, just throwing a comment to stir a conversation on the right approach.
I think the right approach here might be to drop the remoteImage arg and force everyone to use the imageName from DockerImage, since the intention of the interface was to club the operation around an image.
Contributor
Author
There was a problem hiding this comment.
The image handler abstraction is unfortunately a wide mix of "handle one image" and "handle any image" so we'd need a separate effort to try to resolve that.
neel-astro
pushed a commit
that referenced
this pull request
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds an image pull of the latest Ruff image before running it to lint the project. Without this the Ruff image will not update itself as new rules are added.
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft