Upgrades the oapi-generate package#1832
Merged
schnie merged 3 commits intopolaris-mainfrom Apr 15, 2025
Merged
Conversation
schnie
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
schnie
changed the title
oapi-generate package to new location
schnie
changed the title
oapi-generate package to new locationoapi-generate package
schnie
commented
Apr 14, 2025
|
|
||
| func ListConnections(workspaceID, deploymentID string, coreClient astrocore.CoreClient) (map[string]astrocore.EnvironmentObjectConnection, error) { | ||
| envObjs, err := listEnvironmentObjects(workspaceID, deploymentID, astrocore.ListEnvironmentObjectsParamsObjectTypeCONNECTION, coreClient) | ||
| envObjs, err := listEnvironmentObjects(workspaceID, deploymentID, astrocore.CONNECTION, coreClient) |
Member
Author
There was a problem hiding this comment.
I guess the format of constant/enums was changed. Seems like the only actual code change needed.
Contributor
There was a problem hiding this comment.
Losing that prefix is unfortunate, is there no option to get it back? Seems like without the prefix it would be harder to list available values for a field, and they could clash across fields.
Member
Author
There was a problem hiding this comment.
Yea this is weird, I don't know why only this one is affected. The other ones around it seem the same -
astro-cli/astro-client-core/api.gen.go
Lines 1069 to 1074 in a693e01
jeremybeard
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are planning to add new CLI commands that interact with brand new API endpoints for Polaris. I attempted to update our generated clients with
make generate, but ran in the issue shown below. After digging in, it was discovered that this package has been updated and re-located. I've updateddeepmap/oapi-generatetooapi-generate/oapi-generateand it appears to have resolved the issue. It required some minor code updates, but seems to have worked.Fixes this issue:
🎟 Issue(s)
Pre-work for https://github.com/astronomer/astro/issues/29258
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft