Conversation
jeremybeard
requested review from
kushalmalani,
lzdanski and
neel-astro
as code owners
neel-astro
left a comment
neel-astro
left a comment
There was a problem hiding this comment.
This is a great improvement 🚀 , I have left some minor comments to squash but otherwise LGTM
| @@ -0,0 +1,100 @@ | |||
| """ | |||
There was a problem hiding this comment.
I think we would have to update this dag to be compatible with Airflow 3 or replace wit ith other working example short-term
There was a problem hiding this comment.
Hmm it was working but not in the most recent builds. I'll find out whether the DAG is incompatible or if it's a pre-release bug.
There was a problem hiding this comment.
I've updated it to use assets instead of datasets (thanks @TJaniF!) but there are OSS fixes to come before it will succeed.
neel-astro
left a comment
neel-astro
left a comment
There was a problem hiding this comment.
LGTM, I just realized that our integration tests could be improved by adding tests for AF 3 deployments. I am ok with doing it later once there is a final 3.0-0 release so that we don't have to add temporary custom Dockerfile edit logic and also given that we have tested it manually to cover for more cases than the ITs.
@neel-astro @jeremybeard can you create an issue to track that post 3.0 release work? |
3 participants
Description
This change adds support to the CLI for locally running Airflow 3 using the existing
astro devcommands.astro dev initwill automatically begin to initialize new projects using Airflow 3webserverprocess with theapi-serverprocess, which is reflected in the Airflow 3 container names after runningastro dev startdag-processorcontainer, instead of inline in the schedulerastro dev upgrade-checkcommand is removed as it was only applicable for upgrading to Airflow 2.0. Note this is a different command to the still-supportedastro dev upgrade-test🎟 Issue(s)
Resolves #1807
🧪 Functional Testing
astro devcommand📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft