Removed warnings for users if they want to use some other base image other than quay.io inside astro deploy#1806
Merged
neel-astro merged 1 commit intomainfrom Mar 7, 2025
Merged
Conversation
…other than quay.io
rujhan-arora-astronomer
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
neel-astro
approved these changes
Mar 6, 2025
neel-astro
pushed a commit
that referenced
this pull request
Mar 12, 2025
…other than quay.io inside astro deploy (#1806)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed warnings for users if they want to use some other base image other than quay.io inside astro deploy
🎟 Issue(s)
https://github.com/astronomer/issues/issues/6873
🧪 Functional Testing
Tested on local
📸 Screenshots
It can be seen that we didn't ask for any user confirmation for non-quay repo.
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft