Fix logging for astro CLI local parse and pytest commands#1792
Merged
Conversation
neel-astro
pushed a commit
that referenced
this pull request
Feb 19, 2025
Co-authored-by: Pritesh Arora <[email protected]>
BasPH
pushed a commit
that referenced
this pull request
Feb 20, 2025
Co-authored-by: Pritesh Arora <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We recently shipped a change to suppress the image build logs and display user friendly messaging to users but we also suppressed the logs for
astro dev parseandastro dev pytestcommands. As a result these logs are now only available with--versbosity=debugflag, which is not ideal during troubleshooting failures.As part of this PR changes, logs for
astro dev parseandastro dev pytestcommands will be tagged towarnlog level, which is default and therefore user will not have to use--versbosity=debugflag to get these logs in case of error and failures.🎟 Issue(s)
Related #1789
🧪 Functional Testing
Tested the changes locally. Please find the details below:
astro dev parse
Success:
Failure:
astro dev pytest
Success:
Failure:
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft