Implement gzip for dag bundle compression for cloud deploys#1778
Merged
Implement gzip for dag bundle compression for cloud deploys#1778
Conversation
pritt20
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
neel-astro
reviewed
Jan 3, 2025
Contributor
neel-astro
left a comment
neel-astro
left a comment
There was a problem hiding this comment.
LGTM 👍, this would be a great improvement, left a minor nit to squash
neel-astro
approved these changes
Jan 3, 2025
schnie
approved these changes
Jan 3, 2025
rebase with main
neel-astro
pushed a commit
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Pritesh Arora <[email protected]>
neel-astro
pushed a commit
that referenced
this pull request
Jan 10, 2025
Co-authored-by: Pritesh Arora <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements gzip compression for tar dag bundles for cloud based dag only deployments.
This is part of long term solutions that were discussed as part of nova
#nova-20241227-devoid-masswhere it was observed that dag deployment for large dag bundles could take up to 20-30 mins to initiate astro dag only deploy.Links for reference:
https://astronomer.slack.com/archives/C08671SHPUP/p1735582286325009
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
Tested these changes on dev deployment. Please find below details for reference:
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft