Skip to content

Comments

Use CGO enabled for darwin and windows binaries#1776

Merged
neel-astro merged 1 commit intomainfrom
fix-goreleaser
Jan 2, 2025
Merged

Use CGO enabled for darwin and windows binaries#1776
neel-astro merged 1 commit intomainfrom
fix-goreleaser

Conversation

@neel-astro
Copy link
Contributor

@neel-astro neel-astro commented Jan 2, 2025

Description

Enabled CGO for Windows and Darwin CLI binaries to get past the failing build step in the release: https://app.circleci.com/pipelines/github/astronomer/astro-cli/6094/workflows/7df0c652-c8a7-43bb-ac7c-33bfdd29b22e/jobs/12683

For context, we recently upgraded the fsevents indirect dependent library for docker-compose lib, and as a result, build is failing for Darwin if we are using CGO disabled.

Describe the purpose of this pull request.

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

Ran the goreleaser build locally to test the changes:
Screenshot 2025-01-02 at 11 41 14 PM

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link
Member

@schnie schnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@neel-astro neel-astro merged commit 19dea48 into main Jan 2, 2025
@neel-astro neel-astro deleted the fix-goreleaser branch January 2, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants