Skip to content

Comments

Add integration test for Astro CLI dev commands#1765

Merged
schnie merged 5 commits intomainfrom
integration_test
Dec 18, 2024
Merged

Add integration test for Astro CLI dev commands#1765
schnie merged 5 commits intomainfrom
integration_test

Conversation

@pritt20
Copy link
Contributor

@pritt20 pritt20 commented Dec 13, 2024 •
edited
Loading

Description

This PR changes add integration tests and supporting configurations for Astro CLI local development commands.

🎟 Issue(s)

Related #1754

🧪 Functional Testing

Tested these ITs on local python virtual environment:

pytest -x -s -v dev_test.py
================================================================ test session starts =================================================================
platform darwin -- Python 3.11.9, pytest-8.3.4, pluggy-1.5.0 -- /Users/pritt/go/src/github.com/astronomer/astro-cli/integration-test/.venv/bin/python
cachedir: .pytest_cache
rootdir: /Users/pritt/go/src/github.com/astronomer/astro-cli/integration-test
configfile: pyproject.toml
collected 9 items                                                                                                                                    

dev_test.py::test_dev_init PASSED
dev_test.py::test_dev_start PASSED
dev_test.py::test_dev_ps PASSED
dev_test.py::test_dev_logs PASSED
dev_test.py::test_dev_parse PASSED
dev_test.py::test_dev_run PASSED
dev_test.py::test_dev_restart PASSED
dev_test.py::test_dev_export PASSED
dev_test.py::test_dev_kill PASSED

============================================= 9 passed in 65.32s (0:01:05) ==============================================

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@schnie schnie mentioned this pull request Dec 13, 2024
Merged
8 tasks
@pritt20 pritt20 marked this pull request as ready for review December 17, 2024 11:52
neel-astro
neel-astro approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these tests, it's a good start for us.

@schnie schnie merged commit d2482e4 into main Dec 18, 2024
@schnie schnie deleted the integration_test branch December 18, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schnie schnie schnie approved these changes

@neel-astro neel-astro neel-astro approved these changes

@jeremybeard jeremybeard Awaiting requested review from jeremybeard

@kushalmalani kushalmalani Awaiting requested review from kushalmalani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pritt20 @schnie @neel-astro