Introduction of astro deploy --image-name=image_name --remote --runtime-version=rt_version#1763
Merged
neel-astro merged 23 commits intomainfrom Jan 2, 2025
Merged
Introduction of astro deploy --image-name=image_name --remote --runtime-version=rt_version#1763neel-astro merged 23 commits intomainfrom
neel-astro merged 23 commits intomainfrom
Conversation
…orWorkingDir and buildDockerImageForCustomImage) and pushDockerImage. 2. Increased test coverage
…orWorkingDir and buildDockerImageForCustomImage) and pushDockerImage. 2. Increased test coverage
rujhan-arora-astronomer
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
neel-astro
reviewed
Dec 16, 2024
rujhan-arora-astronomer
force-pushed
the
6859
branch
from
ed8b763 to
e55b75c
Compare
neel-astro
reviewed
Dec 17, 2024
Contributor
neel-astro
left a comment
neel-astro
left a comment
There was a problem hiding this comment.
Left some final comments to squash
…unctions for deploy_test.go
…me-version=rt_version
…me-version=rt_version
rujhan-arora-astronomer
force-pushed
the
6859
branch
from
d4302c9 to
37939cc
Compare
neel-astro
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the support for --image-name flag in the astro deploy command. Internally, it will call the updateDeploymentImage API. No image will be pushed to the registry. The command will be like this -
astro deploy --image-name IMAGE_URL --runtime-version IMAGE_RUNTIME_VERSION
🎟 Issue(s)
https://github.com/astronomer/issues/issues/6859
🧪 Functional Testing
locally
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft