Added --image-name flag for software, similar to astro#1758
Merged
neel-astro merged 14 commits intomainfrom Dec 18, 2024
Merged
Added --image-name flag for software, similar to astro#1758neel-astro merged 14 commits intomainfrom
neel-astro merged 14 commits intomainfrom
Conversation
rujhan-arora-astronomer
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
neel-astro
reviewed
Dec 12, 2024
Contributor
neel-astro
left a comment
neel-astro
left a comment
There was a problem hiding this comment.
Left some minor nits, but functionally it looks fine
…orWorkingDir and buildDockerImageForCustomImage) and pushDockerImage. 2. Increased test coverage
…orWorkingDir and buildDockerImageForCustomImage) and pushDockerImage. 2. Increased test coverage
neel-astro
reviewed
Dec 16, 2024
Contributor
neel-astro
left a comment
neel-astro
left a comment
There was a problem hiding this comment.
Left some minor nits, functionally looks ok
neel-astro
reviewed
Dec 17, 2024
Contributor
neel-astro
left a comment
neel-astro
left a comment
There was a problem hiding this comment.
Left a final comment to squash
…unctions for deploy_test.go
neel-astro
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added --image-name flag for software, similar to astro.
If image-name is set, we tag the passed image with our standard tag instead of building a new image and then the rest of the flow remains the same.
The behaviour is the same as astro.
🎟 Issue(s)
Related https://github.com/astronomer/issues/issues/6828
🧪 Functional Testing
locally
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft