Conversation
jeremybeard
requested review from
kushalmalani,
lzdanski and
neel-astro
as code owners
jeremybeard
force-pushed
the
use-new-logger
branch
from
12fcc9f to
1aba57a
Compare
neel-astro
reviewed
Dec 16, 2024
Contributor
neel-astro
left a comment
neel-astro
left a comment
There was a problem hiding this comment.
Thanks for fixing it.
Nit: the logger.Logger wording feels too verbose to use everywhere in the project (not sure why Linter is happy with it 😬😅).
I think either we dot import (not a big fan either 😅 , but don't mind)
Or we could have the log level functions (as public functions) in the cli logger package, with the same function signature as the logrus lib, so that we could directly call logger.Infof (Same as what logrus global log does).
WDYT?
Contributor
Author
|
@neel-astro Yes, agreed. I like the logger functions idea. I've pushed a commit with that and it looks a lot cleaner. |
8 tasks
neel-astro
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This changes the CLI's use of the Logrus logging library to use a new logger instance instead of reusing the existing global logger instance of the library. This prevents debug logs being suppressed when third-party libraries that the CLI imports change the logging level of the global logger, as is at least the case for the use of the Docker Compose package mid-way through
astro dev start.Note that there are other cases where logs are being suppressed because the root "PersistentPreRunE" function that sets up the logging is overridden by some sub-commands. That issue will be fixed in another PR.
🧪 Functional Testing
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft